bradymiller wrote on Saturday, February 13, 2010:
hey,
Here’ review of your code from here:
https://sourceforge.net/tracker/?func=detail&aid=2947585&group_id=60081&atid=1245239
-create fine-grained switches for this stuff in globals.php (iw. switch to turn on/off reminders, healthplans, and clinical alerts)
-overall lack of commenting
-Health plan categories is awkward. sub-categories does not show up in the health plan admin screen. All the health plan names are the same as the categories (ie. not really doing much)…
-the years to repeat function in health plan admin is confusing (seems redundant since have age filter…)
-for clinical alerts notifications consider placing a link in the tree menu grouped with health plans and clinical alerts also to show alerts (then make the popup optional in globals.php, since the popup going everytime one opens a encounter may drive some users insane)
-Cancer health plan makes absolutely no sense. A patient does not get routine cancer prevention health care (missing gi screening also) after they get a cancer. Each of your targets in this plan need to be focused on different sexes and age groups (again, pointing out the weakness of your targets without intervals or filters; in effect each of your cancer targets will need their own health plan to work correctly…)
-Lots of other medical issues with your plans. Why even take on attempting to create correct standard of care health plans? Can’t Maviq give you the health plans they use rather than attempt to build them??? Then can just convert them to your format. Seems like they would do this, since they’ll be getting lots of potential subscribers via OpenEMR in the future.
-When you add a new user, are they placed in all the appropriate health plans that are supposed to be activated for all patients?
-When I placed patch in my development, I got following mysql error if tried to ‘Activate Plan for All Patients’ and click ‘Update’:
ERROR: query failed: INSERT INTO clinical_alerts SET alert_name = ‘Smoking Cessation’, color =‘Black’, plan_id =‘12’, message =‘The patient is a candidate for “Smoking Cessation” health plan. Please consider asking him/her to enroll in the plan.’,past_due_message =‘One or more actions from Smoking Cessation Health Plan is past due. Please check the status with the patient.’
Error: Unknown column ‘past_due_message’ in ‘field list’
individual file reviews below:
interface/batchcom/batch_reminders.php:
-Aren’t the following already covered in classes library/classes/postmaster.php (settings in globals.php):
mail->isMail();
mail->Host = “localhost”;
mail->Mailer = “mail”;
—If so, use the email mechanism you actually created (settings in globals.php), and test to ensure it works.
-Place Maviq’s setting in globals.php
—In the Maviq setting in globals.php, ensure to include a switch to turn it on/off
interface/main/left_nav.php:
-Remove the pseudochanges
-Having the ‘Clinical Alerts’ and ‘Health Plans’ mucks up the ‘Patient/Client’ menu. Place them into an appropriately named folder under ‘Patient/Client’
-Only show links if switched on in globals.php
interface/patient_file/encounter/forms.php:
-Only process if switched on in globals.php
interface/patient_file/health_plans/export.php:
-Seems odd in an open source project to only dump as an excel file. Why not a .csv file?
interface/patient_file/health_plans/health_plans_admin.php:
-Still don’t understand the year to repeat question?
sql/3_2_0-to-3_3_0_upgrade.sql:
-Color list not same as database.sql
-Alert Status list increment seq by 5’s
sql/database.sql
-Color list not same as 3_2_0-to-3_3_0_upgrade.sql
-Alert Status list increment seq by 5’s
-brady