Batch Results Page issues

OpenEMR Development
#1

In Procedures-> Batch Results,
1.When Click on Procedures text box it will open a Modal with name “Types of Orders and Results” in that box there are two buttons, Save, Cancel and Add Top Level. In Add Top Level we can add New level, but is there any specific needs for Save and Cancel Button? Also the cancel is not closing the box.
2.Also in the Procedures-> Batch Results page, The two dates From and To, when clicked on it, it hides the respective textbox clicked. i.e When the From date is clicked, then the Datepicker is displayed above the From date text box, etc.

Kindly refer the attached screenshots.

Save_Cancel_Button
Save_Cancel_Button826×525 11.3 KB
Datepicker_above_date
Datepicker_above_date1154×597 22 KB

Thanks,
ViSolve

#2

Concerning non graceful exits, these seem to occur quit often in this release. They are mostly caused because top frame or left menu no longer exist or what was once a window is now a frame. Maybe a new api function for graceful exiting is needed. This would make a good project for someone wanting to learn OpenEMR code.
I can take a quick look at this issue.

#3

Interesting that the datepicker wants to position to top left of field if there is not any elements below. Save button could be renamed to something more appropriate like Done. Cancel can go and use x-out to destroy dialog.

#4

Hi @sjpadgett,
As you mentioned in the second reply for the page Procedures->Batch Results the cancel button is working in frames but not in Tabs mode of login to OpenEMR. Now in Procedures->Batch Results page, both the window and IFrame closing is handled and a pull request has been created and its submitted to brady.

@brady.miller , The IFrame closing by cancel button is fixed and following is the commit link:

Kindly check and share your views.

Thanks,
ViSolve

#5

Hi @visolveemr ,
Placed a review here: Batch Results page issues by visolve-openemr · Pull Request #1124 · openemr/openemr · GitHub
thanks!
-brady