Audit Engine Bug

bradymiller wrote on Thursday, June 28, 2012:

Hi (have a specific question for Visolve below),

Just committed a bug fix to deal with sql errors that were showing up when saving the Fee Sheet. It was secondary to recently changing the sql call in sql_checksum_of_modified_row() from a sql function that ignored errors to one that died on errors. The short-term solution was to run it through a new sql function that ignores errors.
http://github.com/openemr/openemr/commit/98a204219828fb815c21d3f6dcbe924acbf402e0

Several things come up here:
-Can the sql_checksum_of_modified_row be better optimized by also
  using the binded values
-Can the sql_checksum_of_modified_row be better optimized by improved
  mapping of the incremented values (for example, ar_session and ar_activity are
  not correctly mapped, so just get the SHA1 hash for an empty value
-Can sql_checksum_of_modified_row be optimized to not require
  a sql function that skips errors

And most importantly, is the current implementation of sql_checksum_of_modified_row()
enough to keep certification. I was hoping Visolve could weigh in on this specific question.

-brady
OpenEMR