Administration->Practice->Documents Not Working

system · April 8, 2014, 10:21am

arnabnaha wrote on Tuesday, April 08, 2014:

Hi
When I click on Administration->Practice->Documents, I get a white page of death…

The php error log is this

[08-Apr-2014 10:16:12 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

[08-Apr-2014 10:16:12 UTC] PHP Strict Standards: Non-static method Pharmacy::pharmacies_factory() should not be called statically, assuming $this from incompatible context in C:\xampp\htdocs\openemr\controllers\C_Pharmacy.class.php on line 47

[08-Apr-2014 10:16:13 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

[08-Apr-2014 10:16:13 UTC] PHP Strict Standards: Non-static method Pharmacy::pharmacies_factory() should not be called statically, assuming $this from incompatible context in C:\xampp\htdocs\openemr\controllers\C_Pharmacy.class.php on line 47

[08-Apr-2014 10:16:14 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

[08-Apr-2014 10:16:14 UTC] PHP Strict Standards: Non-static method InsuranceCompany::insurance_companies_factory() should not be called statically, assuming $this from incompatible context in C:\xampp\htdocs\openemr\controllers\C_InsuranceCompany.class.php on line 48

[08-Apr-2014 10:16:14 UTC] PHP Strict Standards: Only variables should be passed by reference in C:\xampp\htdocs\openemr\library\Smarty_Compiler.class.php on line 775

[08-Apr-2014 10:16:15 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

[08-Apr-2014 10:16:15 UTC] PHP Strict Standards: Only variables should be passed by reference in C:\xampp\htdocs\openemr\library\Smarty_Compiler.class.php on line 775

[08-Apr-2014 10:16:15 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

[08-Apr-2014 10:16:15 UTC] PHP Notice: Trying to get property of non-object in C:\xampp\htdocs\openemr\library\classes\ORDataObject.class.php on line 125

[08-Apr-2014 10:16:15 UTC] PHP Notice: Undefined offset: 0 in C:\xampp\htdocs\openemr\library\classes\X12Partner.class.php on line 40

[08-Apr-2014 10:16:15 UTC] PHP Strict Standards: Only variables should be passed by reference in C:\xampp\htdocs\openemr\library\Smarty_Compiler.class.php on line 775

[08-Apr-2014 10:16:16 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

[08-Apr-2014 10:17:06 UTC] PHP Notice: Undefined index: formaction in C:\xampp\htdocs\openemr\interface\super\edit_list.php on line 39

[08-Apr-2014 10:17:06 UTC] PHP Notice: Undefined index: formaction in C:\xampp\htdocs\openemr\interface\super\edit_list.php on line 198

[08-Apr-2014 10:17:06 UTC] PHP Notice: Undefined index: formaction in C:\xampp\htdocs\openemr\interface\super\edit_list.php on line 217

[08-Apr-2014 10:17:09 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

[08-Apr-2014 10:17:09 UTC] PHP Strict Standards: Non-static method Pharmacy::pharmacies_factory() should not be called statically, assuming $this from incompatible context in C:\xampp\htdocs\openemr\controllers\C_Pharmacy.class.php on line 47

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined index: mode in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 35

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined index: fstart in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 163

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined index: search in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 174

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined index: search_reportable in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 175

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined index: search_financial_reporting in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 176

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined variable: count in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 191

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined variable: count in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 194

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined variable: code_type in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 368

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined variable: code in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 391

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined variable: modifier in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 402

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined variable: code_text in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 422

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined variable: superbill in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 433

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined index: edit_options in C:\xampp\htdocs\openemr\library\options.inc.php on line 124

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined variable: cyp_factor in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 448

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined variable: code_type_name_external in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 507

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined variable: code_external in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 508

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined variable: count in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 553

[08-Apr-2014 10:17:10 UTC] PHP Notice: Undefined variable: res in C:\xampp\htdocs\openemr\interface\patient_file\encounter\superbill_custom_full.php on line 594

[08-Apr-2014 10:17:10 UTC] PHP Notice: Trying to get property of non-object in C:\xampp\htdocs\openemr\library\sql.inc on line 289

[08-Apr-2014 10:17:12 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

[08-Apr-2014 10:17:12 UTC] PHP Strict Standards: Non-static method Pharmacy::pharmacies_factory() should not be called statically, assuming $this from incompatible context in C:\xampp\htdocs\openemr\controllers\C_Pharmacy.class.php on line 47

[08-Apr-2014 10:17:13 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

[08-Apr-2014 10:20:20 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

[08-Apr-2014 10:20:20 UTC] PHP Strict Standards: Non-static method Pharmacy::pharmacies_factory() should not be called statically, assuming $this from incompatible context in C:\xampp\htdocs\openemr\controllers\C_Pharmacy.class.php on line 47

[08-Apr-2014 10:20:22 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

[08-Apr-2014 10:20:22 UTC] PHP Notice: Trying to get property of non-object in C:\xampp\htdocs\openemr\library\classes\ORDataObject.class.php on line 125

[08-Apr-2014 10:20:22 UTC] PHP Notice: Undefined offset: 0 in C:\xampp\htdocs\openemr\library\classes\X12Partner.class.php on line 40

[08-Apr-2014 10:20:25 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

[08-Apr-2014 10:20:25 UTC] PHP Notice: Trying to get property of non-object in C:\xampp\htdocs\openemr\library\classes\ORDataObject.class.php on line 125

[08-Apr-2014 10:20:25 UTC] PHP Notice: Undefined offset: 0 in C:\xampp\htdocs\openemr\library\classes\X12Partner.class.php on line 40

[08-Apr-2014 10:20:25 UTC] PHP Strict Standards: Only variables should be passed by reference in C:\xampp\htdocs\openemr\library\Smarty_Compiler.class.php on line 775

[08-Apr-2014 10:20:27 UTC] PHP Strict Standards: Non-static method Controller::act() should not be called statically in C:\xampp\htdocs\openemr\controller.php on line 5

plz help

system · April 8, 2014, 10:52am

arnabnaha wrote on Tuesday, April 08, 2014:

To my surprise…even the New Documents link in the left nav under miscellaneous is also showing white screen of death on clicking

system · April 8, 2014, 11:11am

blankev wrote on Tuesday, April 08, 2014:

This could not be reproduced in the Demo version. Could be a local problem.

system · April 8, 2014, 12:40pm

arnabnaha wrote on Tuesday, April 08, 2014:

Thanks…It might be a windows based problem…can you please take a look at it…it will be of great help…none of the document link is working and it is causing trouble in my regular use

system · April 8, 2014, 1:33pm

blankev wrote on Tuesday, April 08, 2014:

No, I can only compare your troubles with the Demo versions. I can not do anything You need an expert for that.

I would start here:

C:\xampp\htdocs\openemr\controller.php

To find the changes that should be in place, compare your Tree structure on your local machine, with any other version of OpenEMR. I usually have more than one OpenEMR version ont hte computer for reference unde different names, something like:

xampp/htdocs/openemr1
xampp/htdocs/openemr2
(these can be opened as you do with the openemr version you are using)

web browser pointing to … URL localhost/openemr1 or URL localhost/openemr2

Reading my explanation I see the “” used, is like the one used for Linux. Windows uses “/”

Did you install the correct version for Windows?

system · April 10, 2014, 5:49am

bradymiller wrote on Thursday, April 10, 2014:

Hi,

No critical errors showing up in your log above. May want to check the javascript log.

Can any Windows users out this confirm this? There has been recent work in the documents module, so it is very possible that a bug was brought in.

I’ve recently converted to linux os, so can’t easily test windows like I used to. Plan to get a old windows xp appliance going at some point, but may be weeks/months away from doing this. Hopefully can get another developer/user with a available windows environment to test this.

-brady
OpenEMR

system · April 10, 2014, 8:56am

arnabnaha wrote on Thursday, April 10, 2014:

The problem has been solved by Eldho Chako of ZH Healthcare…here is the fix:

In C-Document.class.php under openemr/controller
line no. 165: $tmp = call_user_func($upload_plugin_pp, $value, &$d);

should be changed to

$tmp = call_user_func($upload_plugin_pp, $value, $d);

he told me that this problem is due to my php version. I need to degrade it to 5.3 or in every piece of code has to remove this pass by call reference as a permanent fix. This is temporary.

system · April 10, 2014, 12:46pm

yehster wrote on Thursday, April 10, 2014:

Based on an analysis of the code, the problem only happens if you have a custom upload plugin installed. Hence, the inability to reproduce on the demo servers.

Curious as to what sort of upload post process plugin you are using, but in the meantime, I’ve pushed to correction to the master repository.

https://sourceforge.net/p/openemr/code/ci/c5d7b23e4a44c9b4ec9c70a3f3438c69b54bcf07/

system · April 10, 2014, 2:40pm

iankarlwallace wrote on Thursday, April 10, 2014:

Arnab - In reading the latest documentation for PHP this is going to be a
permanent change - see this page if you want to read more
PHP: Passing by Reference - Manual or the important
part is:

Note: There is no reference sign on a function call - only on function
definitions. Function definitions alone are enough to correctly pass the
argument by reference. As of PHP 5.3.0, you will get a warning saying that
“call-time pass-by-reference” is deprecated when you use & in foo(&$a);.
And as of PHP 5.4.0, call-time pass-by-reference was removed, so using it
will raise a fatal error.

cheers
ian

On Thu, Apr 10, 2014 at 6:46 AM, Kevin Yeh yehster@users.sf.net wrote:

Based on an analysis of the code, the problem only happens if you have a
custom upload plugin installed. Hence, the inability to reproduce on the
demo servers.

Curious as to what sort of upload post process plugin you are using, but
in the meantime, I’ve pushed to correction to the master repository.

https://sourceforge.net/p/openemr/code/ci/c5d7b23e4a44c9b4ec9c70a3f3438c69b54bcf07/

Administration->Practice->Documents Not Workinghttps://sourceforge.net/p/openemr/discussion/202506/thread/e5e7cf81/?limit=25#b653

Sent from sourceforge.net because you indicated interest in
OpenEMR / Discussion / Developers

To unsubscribe from further messages, please visit
SourceForge.net: Log In to SourceForge.net

–
Ian Wallace - Advanced Procedures Fellow - Salud Family Health Center (c)
303.681.5732

system · April 17, 2014, 5:22am

iankarlwallace wrote on Thursday, April 17, 2014:

In looking into this further we have quite a few files that are suspicious
for call-by-reference violations. Using the command “grep -rl “&\$” |
grep .php” in the top of the source code tree yields some ~350+ files that
might have this issue. Many of them in phpMyAdmin or in the gacl, or adodb
sections. In the coming days/weeks I can start taking a look at which ones
look to be really a problem. Don’t think we want to start fixing the
phpMyAdmin/adodb code. I don’t know enough about the gacl stuff really.

List of files from master branch that match attached.

cheers
ian

On Thu, Apr 10, 2014 at 8:40 AM, iankarlwallace <iankarlwallace@users.sf.net

wrote:

Arnab - In reading the latest documentation for PHP this is going to be a
permanent change - see this page if you want to read more
PHP: Passing by Reference - Manual or the important
part is:

Note: There is no reference sign on a function call - only on function
definitions. Function definitions alone are enough to correctly pass the
argument by reference. As of PHP 5.3.0, you will get a warning saying that
“call-time pass-by-reference” is deprecated when you use & in foo(&$a);.
And as of PHP 5.4.0, call-time pass-by-reference was removed, so using it
will raise a fatal error.

cheers
ian

On Thu, Apr 10, 2014 at 6:46 AM, Kevin Yeh yehster@users.sf.net wrote:

Based on an analysis of the code, the problem only happens if you have a
custom upload plugin installed. Hence, the inability to reproduce on the
demo servers.

Curious as to what sort of upload post process plugin you are using, but
in the meantime, I’ve pushed to correction to the master repository.

https://sourceforge.net/p/openemr/code/ci/c5d7b23e4a44c9b4ec9c70a3f3438c69b54bcf07/
Administration->Practice->Documents Not Working
OpenEMR / Discussion / Developers: Administration->Practice->Documents Not Working

Sent from sourceforge.net because you indicated interest in
OpenEMR / Discussion / Developers

To unsubscribe from further messages, please visit
SourceForge.net: Log In to SourceForge.net

–
Ian Wallace - Advanced Procedures Fellow - Salud Family Health Center (c)
303.681.5732

Administration->Practice->Documents Not Workinghttp://sourceforge.net/p/openemr/discussion/202506/thread/e5e7cf81/?limit=25#b653/f267

Sent from sourceforge.net because you indicated interest in
OpenEMR / Discussion / Developers

To unsubscribe from further messages, please visit
SourceForge.net: Log In to SourceForge.net

–
Ian Wallace - Advanced Procedures Fellow - Salud Family Health Center (c)
303.681.5732

system · April 17, 2014, 7:35am

bradymiller wrote on Thursday, April 17, 2014:

Hi,
Pretty sure all the scripts that are used have been dealt with in the past. As an aside, will the Jenkins test suite accurately capture these?
-brady
OpenEMR

system · April 17, 2014, 10:33pm

tmccormi wrote on Thursday, April 17, 2014:

Another great reason to not be packaging phpmyadmin inside our repo…
Tony

–
Please be aware that e-mail communication can be intercepted in
transmission or misdirected. Please consider communicating any sensitive
information by telephone. The information contained in this message may be
privileged and confidential. If you are NOT the intended recipient, please
notify the sender immediately with a copy to hipaa-security@mrsb-ltd.com and
destroy this message.

system · April 18, 2014, 2:38am

iankarlwallace wrote on Friday, April 18, 2014:

Brady - If all of these scripts have been dealt with they don’t pass php’s
lint (syntax checker) on the master branch. I will re-pull the latest
master branch to make sure I have the most up to date files but from what I
can tell each one of these would through a fatal error if someone was
trying to use them.

I will look through the list and just pull out the files that look like
they are from OpenEMR contributors to see if there are lingering
call-by-references to functions. If so I’ll create a branch for the fix
and then submit it once they are corrected.

Tony - Agree. phpMyAdmin while nice for some could probably be yanked at
some point and instructions or a package provided for those who want to add
it to put it back in. A project for another time.

cheers
ian

On Thu, Apr 17, 2014 at 4:33 PM, Tony McCormick tmccormi@users.sf.netwrote:

Another great reason to not be packaging phpmyadmin inside our repo…
Tony

–
Please be aware that e-mail communication can be intercepted in
transmission or misdirected. Please consider communicating any sensitive
information by telephone. The information contained in this message may be
privileged and confidential. If you are NOT the intended recipient, please
notify the sender immediately with a copy to hipaa-security@mrsb-ltd.comand
destroy this message.

Administration->Practice->Documents Not Workinghttp://sourceforge.net/p/openemr/discussion/202506/thread/e5e7cf81/?limit=50#b653/f267/7e5f/44a0

Sent from sourceforge.net because you indicated interest in
OpenEMR / Discussion / Developers

To unsubscribe from further messages, please visit
SourceForge.net: Log In to SourceForge.net

–
Ian Wallace - Advanced Procedures Fellow - Salud Family Health Center (c)
303.681.5732

system · April 18, 2014, 3:53am

iankarlwallace wrote on Friday, April 18, 2014:

After a much better examination of the files here’s the list of files that
have problems:

Fatal error: Call-time pass-by-reference has been removed in
openemr/controllers/C_Document.class.php on line 164
Fatal error: Call-time pass-by-reference has been removed in
openemr/library/freeb/xmlrpc_server.php on line 24
Fatal error: Call-time pass-by-reference has been removed in
openemr/interface/main/calendar/pnadodb/adodb-xmlschema.inc.php on line 461
Fatal error: Call-time pass-by-reference has been removed in
openemr/interface/main/calendar/pnadodb/drivers/adodb-oracle.inc.php on
line 219
Fatal error: Call-time pass-by-reference has been removed in
openemr/interface/patient_file/download_template.php on line 70
Fatal error: Call-time pass-by-reference has been removed in
openemr/gacl/adodb/drivers/adodb-oracle.inc.php on line 289
Fatal error: Call-time pass-by-reference has been removed in
openemr/gacl/admin/acl_test3.php on line 71
Fatal error: Call-time pass-by-reference has been removed in
openemr/gacl/admin/acl_test2.php on line 51
Fatal error: Call-time pass-by-reference has been removed in
openemr/gacl/test_suite/phpunit/phpunit.php on line 204

My initial analysis was a little too broad of a grep statement as was
picking up both the function definitions and some HTML that had things that
looked like “&$” in the URL’s.

Much more manageable.

cheers
ian

On Thu, Apr 17, 2014 at 8:38 PM, iankarlwallace <iankarlwallace@users.sf.net

wrote:

Brady - If all of these scripts have been dealt with they don’t pass php’s
lint (syntax checker) on the master branch. I will re-pull the latest
master branch to make sure I have the most up to date files but from what I
can tell each one of these would through a fatal error if someone was
trying to use them.

I will look through the list and just pull out the files that look like
they are from OpenEMR contributors to see if there are lingering
call-by-references to functions. If so I’ll create a branch for the fix
and then submit it once they are corrected.

Tony - Agree. phpMyAdmin while nice for some could probably be yanked at
some point and instructions or a package provided for those who want to add
it to put it back in. A project for another time.

cheers
ian

On Thu, Apr 17, 2014 at 4:33 PM, Tony McCormick tmccormi@users.sf.net
wrote:

Another great reason to not be packaging phpmyadmin inside our repo…
Tony

–
Please be aware that e-mail communication can be intercepted in
transmission or misdirected. Please consider communicating any sensitive
information by telephone. The information contained in this message may be
privileged and confidential. If you are NOT the intended recipient, please
notify the sender immediately with a copy to hipaa-security@mrsb-ltd.comand
destroy this message.

Administration->Practice->Documents Not Working
OpenEMR / Discussion / Developers: Administration->Practice->Documents Not Working

Sent from sourceforge.net because you indicated interest in
OpenEMR / Discussion / Developers

To unsubscribe from further messages, please visit
SourceForge.net: Log In to SourceForge.net

–
Ian Wallace - Advanced Procedures Fellow - Salud Family Health Center (c)
303.681.5732

Administration->Practice->Documents Not Workinghttp://sourceforge.net/p/openemr/discussion/202506/thread/e5e7cf81/?limit=25#b653/f267/7e5f/44a0/a1d4

Sent from sourceforge.net because you indicated interest in
OpenEMR / Discussion / Developers

To unsubscribe from further messages, please visit
SourceForge.net: Log In to SourceForge.net

–
Ian Wallace - Advanced Procedures Fellow - Salud Family Health Center (c)
303.681.5732